Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7438 closed defect (bug) (fixed)

New Member input box looks visually like a label on group edit page

Reported by: Ankit K Gupta Owned by: mercime
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7.2
Component: Groups Keywords: has-patch commit has-screenshots
Cc: ankitgupta.sqa@…

Description

On group edit page we have an input box with placeholder text for adding new member but this box seems simple text/label due to no border on input box.
If we add 1px border, It increases accessibility for user point of view.

Attachments (5)

7438.patch (414 bytes) - added by Ankit K Gupta 3 years ago.
added patch
group-edit-before-fix.png (37.6 KB) - added by Ankit K Gupta 3 years ago.
group-edit-after-fix.png (30.3 KB) - added by Ankit K Gupta 3 years ago.
7438.2.patch (1.7 KB) - added by mercime 3 years ago.
add-new-members.gif (12.8 KB) - added by mercime 3 years ago.

Download all attachments as: .zip

Change History (14)

@Ankit K Gupta
3 years ago

added patch

#1 @Ankit K Gupta
3 years ago

  • Summary changed from Input box looks label on group edit page to Input box looks like a label on group edit page

#2 @DJPaul
3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.8
  • Owner set to mercime
  • Status changed from new to assigned
  • Summary changed from Input box looks like a label on group edit page to Input box looks label on group edit page

Looks like a no-brainer. Thanks for the patch @Ankit K Gupta

#3 @Ankit K Gupta
3 years ago

Thanks, @DJPaul for accepting the patch and quick response.
Response in only 26 seconds. Awesome!

#4 @DJPaul
3 years ago

Not guaranteed for all new tickets, haha :)

#5 @hnla
3 years ago

  • Summary changed from Input box looks label on group edit page to New Member input box looks visually like a label on group edit page

#6 @mercime
3 years ago

Thank you @ankit-k-gupta :) Attaching new patch with screenshot:

  • adds a missing type="text" to that input box and thus in effect, inherits the :focus styles of wp-admin stylesheet
  • remove max-width from input box and adds top margin for equidistant margins around it
Last edited 3 years ago by mercime (previous) (diff)

@mercime
3 years ago

#7 @mercime
3 years ago

  • Keywords has-screenshots added

#8 @slaFFik
3 years ago

@mercime, I like your patch.
Can we push it sooner than later?

#9 @mercime
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11416:

Groups: Add missing type attribute and styles for Group > Edit input control.

Props ankit-k-gupta.
Fixes #7438.

Note: See TracTickets for help on using tickets.