Opened 9 years ago
Closed 9 years ago
#7432 closed defect (bug) (fixed)
Test depends on PHP EXIF support; should fail more gracefully when absent
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 2.9 | Priority: | normal |
| Severity: | normal | Version: | 2.4.0 |
| Component: | Media | Keywords: | has-patch |
| Cc: |
Description
Related: #7019
If PHP is not compiled with EXIF support, BP_Tests_BP_Attachment_TestCases::test_bp_attachment_get_image_data() fails. The test is written in a way that makes it dependent on data fetched via exif_read_data() (as opposed to some of the other data fetched by wp_read_image_metadata()). I think this is probably fine, but we should skip the test if EXIF support is not in place:
if ( ! is_callable( 'exif_read_data' ) ) {
$this->markTestSkipped( 'This test requires PHP to be compiled with EXIF support.' );
}
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
This one was annoying me a bit.
01.patchalso skips tests that require PHP to have either the GD or Imagemagick extension enabled.