#7423 closed defect (bug) (fixed)
Group Types Default Pagination Broken
Reported by: | reubenlillie | Owned by: | r-a-y |
---|---|---|---|
Milestone: | 2.8 | Priority: | normal |
Severity: | normal | Version: | 2.7 |
Component: | Groups | Keywords: | has-patch commit |
Cc: |
Description
Expected: Pagination links appearing for group type listings with over "n" results (n = 20 by default) would navigate to their respective pages.
Actual: Links appear active (e.g., cursor changes on focus/hover, href exists), but both next-page and numbered links fail to load. That is, it is currently impossible for users with a default BP installation to navigate to groups listed beyond the "nth" result when viewing by group type.
Query issue?
Template issue?
NB: Functionality works as expected when viewing "All Groups" listing but not when viewing by "group type" (2.6+).
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.
8 years ago
#3
@
8 years ago
- Keywords has-patch added; ui-feedback removed
- Milestone changed from Future Release to 2.8
- Owner set to r-a-y
- Priority changed from high to normal
- Status changed from new to assigned
- Version changed from 2.7.2 to 2.7
#4
@
8 years ago
@r-a-y I wanted to add some tests for the correct behavior. I've no idea why the last two new tests are failing. (bp_current_action()
is returning type
, even though I can verify in an actual install that the behavior is correct. Maybe it's a quirk with go_to
? Any ideas?)
Also, the member directory tests are in routing/members.php
, rather than members/types.php
, so there's some doubt that I've added them in the right spot.
#5
@
8 years ago
Maybe it's a quirk with go_to? Any ideas?)
This. We only run 'bp_init'
on the go_to()
method because we can't really test for redirections using wp_redirect()
. If we do try to run the 'bp_template_redirect'
hook in the go_to()
method, PHPUnit will crap out.
Instead of redirecting, we could change invalid group type requests to 404 instead. That way, we would be in line with what we are currently doing with invalid member type requests.
This is a legit bug that only occurs if there is more than one page of groups on a group type directory.
There are two issues:
BP_Groups_Component::setup_globals()
method, we throw a 404 for group pages that is not a single group page or the group creation page. This meant that the AJAX call was throwing a 404.BP_Groups_Component
class so this can be picked up by AJAX.Patch fixes this both up. Was an oversight on my part!
Would love to squeeze this in for BP 2.8, since this bug was introduced in 2.7.