Opened 8 years ago
Closed 7 years ago
#7400 closed enhancement (wontfix)
Allow Multiple activity loop on same page work properly
Reported by: | sbrajesh | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Templates | Keywords: | has-patch 2nd-opinion |
Cc: | brajesh@… |
Description
At the moment, it is possible to create multiple activity loops and have them on same page.
The problem lies the way current js is implemented it. The code does not differentiate between the different loops and if you do any action on one of the loop items, the other loop gets affected.
For example:-
- Load more items in first loop, all other loops will have the same done
- Filtering of activity using the selectboxes, all other loops gte filtered
- same goes for comment/reply etc
The problem lies with the javascipt code, It should be scoped to the the loop.
Please find a patch attached. I will be happy to help get it working, please let me know your suggestions for improving the patch.
Attachments (1)
Change History (5)
#1
@
8 years ago
- Keywords has-patch 2nd-opinion added
- Milestone changed from Awaiting Review to Under Consideration
#2
@
8 years ago
I'd personally prefer to see this sort of testing and enhancement to be done with BP-Nouveau, not BP-Default.
@slaFFik don't let perfect become the enemy of better.
Thanks for the patch, @sbrajesh!
That's for the activity, and what about groups, members, blogs etc loops?
Shouldn't we create something universal?