PHP 7 compatibilty issues with the bbpress version bundled with BuddyPress

[xknown]

The bbpress version bundled with buddypress has quite a few PHP7 compatibility issues. I fixed most of them in the 1.2 bbpress branch --- ​http://bbpress.svn.wordpress.org/branches/1.2/.
It'd be great if we could update the svn external in bp-forums to http://bbpress.svn.wordpress.org/branches/1.2/ as shown below or http://bbpress.svn.wordpress.org/tags/1.2.1/ (it doesn't exist yet)

Index: bp-forums
===================================================================
--- bp-forums   (revision 11295)
+++ bp-forums   (working copy)

Property changes on: bp-forums
___________________________________________________________________
Modified: svn:externals
## -1 +1 ##
-bbpress http://bbpress.svn.wordpress.org/tags/1.2/
+bbpress http://bbpress.svn.wordpress.org/branches/1.2/

[DJPaul]

No problem. I'd prefer if a new bbPress 1.2.x can be tagged, we'll switch our external to it.

[johnjamesjacoby]

Thanks @xknown. Tagged 1.2.1 here: ​[BB6169]

[djpaul]

In 11297:

Legacy forums: switch external to bbPress 1.2.1 for improved PHP7 support.

Fixes #7389