Opened 8 years ago
Closed 8 years ago
#7375 closed defect (bug) (fixed)
Accepting/rejecting group membership request should mark notification read for all group admins
Reported by: | boonebgorges | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 2.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Groups | Keywords: | has-patch 2nd-opinion |
Cc: | dcavins |
Description
- Three users: A, B, and C.
- A and B are admins of the private group
Foo
- C requests membership to
Foo
- A gets the email first, and visits the group membership page to accept/reject the request. When that page loads, A's corresponding notification is marked as read.
- B's notification remains unread, even after A accepts/rejects.
This seems like a bug, right? The one concern would be if B shows up later to confirm the request, the notification will be missing. But I think it's clear enough in this case that the request has been handled by another admin.
Patch attached.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
I agree that the behavior you're suggesting makes more sense than leaving confusing notifications that can't be acted upon. Your patch looks good to me (passing the
null
value for user ID is clever and kind of surprising). Thanks for catching this weird behavior.