Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#7375 closed defect (bug) (fixed)

Accepting/rejecting group membership request should mark notification read for all group admins

Reported by: boonebgorges Owned by: boonebgorges
Priority: normal Milestone: 2.8
Component: Groups Version:
Severity: normal Keywords: has-patch 2nd-opinion
Cc: dcavins

Description

  1. Three users: A, B, and C.
  2. A and B are admins of the private group Foo
  3. C requests membership to Foo
  4. A gets the email first, and visits the group membership page to accept/reject the request. When that page loads, A's corresponding notification is marked as read.
  5. B's notification remains unread, even after A accepts/rejects.

This seems like a bug, right? The one concern would be if B shows up later to confirm the request, the notification will be missing. But I think it's clear enough in this case that the request has been handled by another admin.

Patch attached.

Attachments (1)

7375.diff (2.8 KB ) - added by boonebgorges 10 years ago.

Download all attachments as: .zip

Change History (3)

@boonebgorges
10 years ago

#1 @dcavins
10 years ago

  • Cc dcavins added

I agree that the behavior you're suggesting makes more sense than leaving confusing notifications that can't be acted upon. Your patch looks good to me (passing the null value for user ID is clever and kind of surprising). Thanks for catching this weird behavior.

#2 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolutionfixed
  • Status newclosed

In 11278:

When a group membership request is approved or rejected, mark all related notifications as read.

Fixes #7375.

Note: See TracTickets for help on using tickets.