PHP Fatal error: Uncaught Error: Call to a member function get_do_autolink() on null

[slaFFik]

Got this error:

PHP Fatal error:  Uncaught Error: Call to a member function get_do_autolink() on null in wp-content\plugins\buddypress\bp-xprofile\bp-xprofile-filters.php:344

in one of my plugins, when doing this:

$field_link = xprofile_filter_link_profile_data( $field_value, $field_data['type'] );

There is no $field; defined, using this function in ajax request.
I've fixed that in a plugin by defining the global with xprofile_get_field( $field_id ) in my loop, but shouldn't we consider checking the $field for not being null (or better instanceof BP_XProfile_Field) before using its method get_do_autolink()?

[slaFFik]

Add additional check

[DJPaul]

I ran into this while writing a unit test last week. While not ideal, the current function is written to be used inside the xprofile template loop. This patch just prevents a fatal error when it's used wrong; it doesn't make the function usable outside the template loop. And that's what the function ought to be changed for, if we're going to change it at all.

[DJPaul]

I'm not convinced that this is a worthwhile change. Opinions?

[r-a-y]

I agree with Paul. The current patch doesn't change how the xprofile_filter_link_profile_data() function works.

@slaFFik - I would rework the patch so we add a third parameter - $field_id - to xprofile_filter_link_profile_data(). This is so the 'bp_get_the_profile_field_value' filter will continue to work as-is.

Then instead of looking at the $field global in the xprofile_filter_link_profile_data() function, we do $field = xprofile_get_field( $field_id );.

Then in your custom AJAX call, you could do this:
xprofile_filter_link_profile_data( $field_value, $field_data['type'], $field_id )

[r-a-y]

Bumping back to Awaiting Review.

[DJPaul]

Still unconvinced. Adapting a template loop function to be used outside seems against the design intent of those functions.

[r-a-y]

I'm not convinced either, but do we want to safeguard the function from being used outside the xprofile loop?

If so, the current patch or a variation of it could be done (like empty( $GLOBALS['field'] )).

[DJPaul]

Let's not do this.