Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#733 closed enhancement (fixed)

Localization Enhancement (Patch Included)

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: apeatling's profile apeatling
Milestone: Priority: major
Severity: Version: 1.0
Component: Keywords: has-patch
Cc:

Description

This will reprioritize BuddyPress to play nicer with friends and other plugins. (priority 2 instead of 1)

bp_load_buddypress_textdomain function introduced and hooked into plugins_loaded to allow plugins the opportunity to play with language settings before loading BuddyPress translation files.

Attachments (1)

bp-core.patch (6.2 KB) - added by johnjamesjacoby 13 years ago.
Replacement bp-core.php (added filters and functions)

Download all attachments as: .zip

Change History (6)

#1 @johnjamesjacoby
13 years ago

  • Keywords has-patch added

@johnjamesjacoby
13 years ago

Replacement bp-core.php (added filters and functions)

#2 @johnjamesjacoby
13 years ago

Just updated the patch. Added some things I could see using; filters, functions, etc...

Namely two functions, for getting the current member theme path and URL. These can later be used to get the remaining CSS files out of the plugins/buddypress directory and into the member themes.

This is important for theme authors because CSS isn't event driven like PHP/WordPress is, it cascades the style that is set before it. !important tags in CSS should be avoided, and having to know which style was already applied to an element in a core file previously just to reset that element and then restyle it again, is something foreign to most people (especially considering that all current WordPress themes keep *all* CSS in the theme folder. It further prevents novices from editing core files and having their CSS edits over-written by a core update later.

#3 @johnjamesjacoby
13 years ago

It should be noted that in order for other core plugins to take advantage of the new functions, their respective "_add_css" functions must be patched to replace the current "BP_PLUGIN_URL + path/to/file" reference and instead use these functions.

I figure I'll let this suggestion stew in the event it gets vetoed. :)

#4 @(none)
13 years ago

  • Milestone Core 1.1 deleted

Milestone Core 1.1 deleted

#5 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This has been fixed a while ago and current trunk code makes this patch no longer relevant.

Note: See TracTickets for help on using tickets.