Possible php warnings in bp_legacy_theme_delete_activity_comment()

[Jonas Lundman]

Issue in

bp_legacy_theme_delete_activity_comment()

This call:

$comment = new BP_Activity_Activity( $_POST['id'] );

is done before verifying the POST id :

if ( empty( $_POST['id'] ) || ! is_numeric( $_POST['id'] ) )
		exit( '-1' );

PHP warnings breaks the response

[slaFFik]

Jonas Lundman, thanks for your first submitted issue!

I don't see any problems in reordering some lines with checks in this function. I will prepare the patch.

[DJPaul]

This needs a new patch @slaFFik . It should JUST make the change described in this ticket to fix it; the other code improvements should go in separately. What I normally do when about to commit patches like this, is do a commit just for the fix, then a second commit for the miscellaneous improvements. But when sharing a patch up for review, it's as concise and as targeted as possible.

[slaFFik]

@DJPaul
Thanks for your insights. I will redo the patch.

[slaFFik]

Removed some code cleanup

[slaffik]

In 11270:

Prevent possible warning in bp_legacy_theme_delete_activity_comment().

Firstly, check $_POST['id'] itself, only after that - for logged-in user status. Prevents warnings when the AJAX request is sent with wrong params, which doesn't allow to proceed and run additional code.

Props jonas-lundman.
Fixes #7324.