Skip to:
Content

Opened 11 months ago

Last modified 7 weeks ago

#7312 new enhancement

Don't show the sorting box and the meta information

Reported by: mchansy Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Groups Keywords:
Cc:

Description

I don't need the sorting box (New, Last, Active) and the meta information to the group into the Group Widget.

Attachments (2)

class-bp-groups-widget.php.patch (4.1 KB) - added by mchansy 11 months ago.
group-member-friend-widget.patch (17.4 KB) - added by mchansy 11 months ago.
Patch the group, members and friend widget

Download all attachments as: .zip

Change History (19)

#1 @slaFFik
11 months ago

  • Milestone changed from Awaiting Review to Future Release

#2 @DJPaul
11 months ago

  • Milestone changed from Future Release to Under Consideration

#3 @slaFFik
11 months ago

I believe same should be implemented for other BuddyPress widgets with sorting (members, friends).

@mchansy, could you please prepare the patch for other widgets as well? That would be really awesome :)

#4 @mchansy
11 months ago

No Problem, i do it.

#5 @hnla
11 months ago

  • Milestone changed from Under Consideration to 2.8

This a good enhancement, but as slaFFik says we need to ensure all widgets have the same capability.

With the above I'm just noting here an further anomaly that should be dealt with in that all widgets allow titles to be set EXCEPT! friends widget that instead as oddly a hard coded title which when logged in refers to yourself in the third person which is distinctly odd, but unchangeable Admins Friends it's not nor can be a general displayed item but only ever in reference to yourself so ought to really be My Friends the former though will need retaining as a default for backpat concerns thoug.h :(.

I'll ticket this separately and update that widget to accept a title field.

#6 @DJPaul
11 months ago

The widgets generally have been ignored forever. If someone wants to rewrite them and make them better, or have ideas for new widgets, then go for it -- but that won't by itself block an improvement for one of the widgets being added.

@mchansy Thanks for the ticket and for the patch; your first, I think!

@mchansy
11 months ago

Patch the group, members and friend widget

#7 @mchansy
11 months ago

The new Patch include the checkboxes for the three widget: Friend, Members and Groups.
And also include the option alpabetical (Ticket #7313) sort for the three widget.

#8 @hnla
11 months ago

@mchansy great stuff thanks for the patch we'll check it over, one thing though did you build this patch from BP trunk, root directory as I'm not reading the /src/ directory in the patch dir paths, needed to hack those paths to begin /src/ to run the patch.

#9 @hnla
11 months ago

I'm seeming undefined indexes on the two new settings for sort and meta where widgets were already being displayed.

#10 @mchansy
11 months ago

How can reproduce the Problem? Do you see a error message?

#11 @hnla
11 months ago

@mchansy
If your running trunk and the following set true in wp-config:

define('WP_DEBUG', true);
define('SCRIPT_DEBUG', true);

I had the widgets already loaded/activated before running the patch so the items weren't set throwing an undefined index, going back in and saving the widget defined them though, a while since I played with widget code had thought they would have been defined from what I saw briefly looking.

#12 @hnla
11 months ago

I think isset() is a better check.

This is likely a technicality but looking at things think in a way BP only avoids an error as the widget is loaded into a sidebar and then auto saved if it weren't then things like $instance['title'] would throw an undefined index too.

I'm thinking that really those widgets need to set default args earlier and parse with $instance[]?

I may be reading this incorrectly though! :)

#13 @slaFFik
11 months ago

I believe this change in widgets should be done with #6754.

#14 @DJPaul
8 months ago

  • Keywords early added
  • Milestone changed from 2.8 to 2.9

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


4 months ago

#16 @hnla
3 months ago

  • Keywords changed from has-patch, early to has-patch early
  • Milestone changed from 2.9 to 3.0

#17 @DJPaul
7 weeks ago

  • Keywords has-patch early removed
Note: See TracTickets for help on using tickets.