#7307 closed defect (bug) (fixed)
Loading deprecated code
Reported by: | DJPaul | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 2.8.1 | Priority: | high |
Severity: | normal | Version: | 2.7 |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
In 2.7 with #6839, we stopped loading bp-core/deprecated/*
for new installs. It's only meant to load for existing sites (updates).
A forum report at https://buddypress.org/support/topic/call-to-undefined-function-bp_blogs_get_subdomain_base/#post-260338 detailed an old theme (Kleo) calling a 2.1-deprecated. I don't know yet why the deprecated files are not being loaded on an existing site (maybe they are and the root cause is something else), but we need to check on that behaviour.
As a result of looking at that, we still have at least a few functions in those deprecated files still being loaded. For example, grep for bp_blogs_subdomain_base
and bp_blogs_get_subdomain_base
. There may be others.
Attachments (1)
Change History (16)
This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.
8 years ago
#10
@
8 years ago
- Milestone changed from Future Release to 2.8.1
- Priority changed from normal to high
Just got a user report about deprecated code not being loaded due to deprecated functions being called from the Blogs component:
https://buddypress.org/support/topic/v2-8-undefined-function-in-mu-when-creating-site/
To duplicate, set up a new subdomain multisite install on a fresh BuddyPress instance. Next, navigate to example.com/blogs/create/
and you'll see the fatal error since we no longer load deprecated code on new BP installs.
This is important to fix, so I'm moving this to the 2.8.1 milestone.
#12
@
8 years ago
- Keywords has-patch added; needs-patch removed
01.patch
fixes the deprecated blog function call and also loads up the deprecated BuddyBar code if a BP install has chosen to force-enable the BuddyBar, but is not loading deprecated code via the BP_IGNORE_DEPRECATED
constant or a filter.
We have to do the latter since we still reference the BuddyBar in core.
I want to revert r11105 for 2.7 branch and leave the ticket open to investigate, correct, and fix things in trunk for 2.8. Thoughts?