Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 3 years ago

#7306 closed defect (bug) (fixed)

Incorrect? PHPDoc for bp_xprofile_get_meta

Reported by: djpaul's profile DJPaul Owned by: espellcaste's profile espellcaste
Milestone: 10.0.0 Priority: normal
Severity: normal Version: 2.7
Component: Extended Profile Keywords: has-patch
Cc:

Description

Per #7300, the bp_xprofile_get_meta function says it returns a bool, but it actually returns an empty string.

Figure out what it's meant to do, and change the PHPDoc or update existing uses as appropriate.

Attachments (1)

7306.patch​ (1.2 KB) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (7)

#1 @slaffik
8 years ago

In 11350:

Profile: Improve bp-xprofile-template.php PHPDoc comments.

Added some proper casting for (int) and fixed @return statements, where we previously had mixed|void for some reason.

See #7306.

#2 @DJPaul
8 years ago

  • Milestone changed from 2.8 to Future Release

#3 @espellcaste
3 years ago

  • Milestone changed from Awaiting Contributions to 10.0.0
  • Owner set to espellcaste
  • Status changed from new to assigned

Based on the committed code, this ticket should be resolved. But I'll move this to the 10 milestone for another eye and decision. :)

#4 @imath
3 years ago

  • Keywords has-patch added

The committed code is not about the bp_xprofile_get_meta() function. The attached patch should fix the issue.

@imath
3 years ago

#5 @espellcaste
3 years ago

@imath Thanks! That's correct!

#6 @espellcaste
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed via this commit: ​https://buddypress.trac.wordpress.org/changeset/13088

Note: See TracTickets for help on using tickets.