Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 7 years ago

#7293 closed defect (bug) (no action required)

PHP7 compatibility issues

Reported by: prowo24's profile prowo24 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-testing
Cc:

Description (last modified by slaFFik)

Hello,

the Plugin "PHP Compatibility checker" displays the following issues for compatibility of buddypress and php7.

FILE: /is/htdocs/wp11082020_GHQ53PBT44/www/portal/wp-content/plugins/buddypress/bp-core/classes/class-bp-core-nav.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 394 | ERROR | 'clone' is a reserved keyword introduced in PHP version 5.0 and cannot be invoked as a function (T_CLONE)
-------------------------------------------------------------------------------------------------------------------------

The rest of PHP7 incompatibility regarding bundled bbpress1 was moved to http://pastebin.com/hYaV5bY8


@slaFFik edited description to make it readable.

Change History (4)

#1 @slaFFik
8 years ago

  • Keywords needs-testing added; needs-patch removed
  • Version 2.6.2 deleted

Only the first issue might be related to the core, actually.
/bp-forums/bbpress/* are a 3rd party plugin, that is (sadly) distributed with BuddyPress. We can't do much there, just remove it (perhaps to a separate plugin).

I'm personally using BuddyPress 2.6.2 on a PHP 7 - don't have any issues (that I noticed to be fair).

Anyway, we have tests, that are passing green on PHP 7 (and particularly regarding that class-bp-core-nav.php), but we will recheck.

#2 @slaFFik
8 years ago

  • Description modified (diff)

#3 @tw2113
8 years ago

Related #7184

As far as I can tell, the line highlighted in the ticket is already covered. The bbPress ones from the pastebin are likely already getting addressed by bbPress core devs.

#4 @DJPaul
7 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

This was fixed in r10943 in BuddyPress 2.7. Thank you for letting us know, @prowo24 -- better safe than sorry!

Note: See TracTickets for help on using tickets.