Members can't dismiss sitewide notices

[slaFFik]

When admin creates a notice (sitewide) and activate it, site members see it on every page as a bug yellow banner.
They used to have dismis icon some time ago, currently they can't dismiss it and continue to see it over and over again.

Using BuddyPress trunk.

[DJPaul]

@slaFFik Did you test this in 2.6 to see if we broke it for 2.7?

[slaFFik]

Right now on a production BuddyPress 2.6.2 I see the dismiss link.

<a href="#" id="close-notice">Close</a>

[DJPaul]

You didn't say if it *worked* :) but I am assuming it works on 2.6 but not 2.7. Let's check and verify before 2.7 RC2.

[slaFFik]

Just retested with more carefulness.
Trunk BuddyPress - dismiss link both appears and works in 2015 theme.
Possible reason why I missed it previously - I had a very long notice text, and Close link doesn't have any special styles, it looks like regular text. I just overlooked it, my bad :(
Closing the ticket.

[slaFFik]

@hnla
What about adding some special line or 2 of styles for this link, so it will be more visible and be actually a link (visually)? With dotted border-bottom, or color changes.

[hnla]

@slaFFik @DJPaul hows about we sneak through a update to that link; lets change it to a bullet element and let it inherit themes bullet styling which in most cases would be far more prominent visually and more in keeping with it's functions and the way we're heading with templates and elements.

[slaFFik]

You mean the bullet for Close link only? Or the whole notice content (one li for content, another li for Close)?

[hnla]

@slaFFik my bad I meant to say button element as in <button type="button class="button> but yes just for the actual link 'Close' would mean checking how we're catching the current link action to ensure it continues working and would perhaps upset some themes but easily unstyled.