Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7256 closed enhancement (fixed)

Accessibility: Differentiate navigation landmarks in front-end templates

Reported by: mercime Owned by: mercime
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

We have twenty navigation landmarks throughout the bp-legacy templates. Add one or more navigation landmarks from the theme side, that can get confusing for users of assistive technologies.

We need to clarify what our navigation landmarks are in relation to the other navigation landmarks and the whole screen by adding aria-labels.

Attachments (3)

7256-general.patch (12.2 KB) - added by mercime 3 years ago.
7256-general-2.patch (17.0 KB) - added by mercime 3 years ago.
Add overlooked navigation landmarks
7256-general-3.patch (17.1 KB) - added by mercime 3 years ago.

Download all attachments as: .zip

Change History (11)

#1 @mercime
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.7

Attached patch gives a general overview of each primary and secondary navigation elements. We could make each specific e.g. Group settings menu, Member profile menu, etc. What do you think? :)

@mercime
3 years ago

Add overlooked navigation landmarks

#2 @DJPaul
3 years ago

When these go in, can we update BP-Nouveau with these? Any accessibility enhancements we make with BP-Legacy should be copied into BP-Nouveau where they can/

#3 @mercime
3 years ago

@DJPaul Yes. I have also mentioned to hnla that I contribute to bp-nouveau after BP 2.7 rolls out :)

Updated patch removes navigation role for Group create tabs and changes menu for navigation.

#4 @mercime
3 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11128:

Accessibility: Differentiate navigation landmarks for screen readers.

Fixes #7256.

#5 @dcavins
3 years ago

In 11137:

Specify text domain in string translation function.

Fixes problem with bp-legacy/groups/index.php introduced in r11128.

See #7256.

#6 @r-a-y
3 years ago

In 11148:

bp-legacy: Add back missing <ul> in Members Directory template part.

See r11128.

See #7256.

#7 @mercime
3 years ago

In 11170:

Add navigation role to profile field group links in Profile > Edit screen.

See #7256.

#8 @mercime
3 years ago

In 11172:

Correct the value for aria-label in commit r11170.

Antiprops mercime.
See #7256.

Note: See TracTickets for help on using tickets.