Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7229 closed defect (bug) (fixed)

Group Directory classes (e.g. group-button) should be consistent after ajax request.

Reported by: dunhakdis Owned by: boonebgorges
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

Hello, everyone!

When I go to the group's directory, I noticed that when I clicked the join button or leave group button, the .group-button class disappears in the anchor tag.

I am building a BuddyPress theme, and I found this to be quite inconsistent. For example, If I hook my styling to the said class after the user joins or leave the group, the button will be styleless because the said class (.group-button) disappears.

I went to buddypress-functions.php and add the classes and finally it works :)

I know that we can overwrite the file in our theme, but I think that it will be great if we can add this class to the default theme so that we do not need to overwrite the file anymore.

Please see this image (https://s3.amazonaws.com/image-turbo/public/Screen+Shot+2016-08-24+at+10.54.05+AM.png) for illustration.

Thanks!

Best Regards,
Joseph

Attachments (1)

buddypress-functions.patch (3.3 KB) - added by dunhakdis 3 years ago.

Download all attachments as: .zip

Change History (4)

#1 @boonebgorges
3 years ago

  • Milestone changed from Awaiting Review to 2.7
  • Version 2.6.3 deleted

@dunhakdis Thanks very much for the ticket! I looked through the logs, and it appears that the group-button class has been missing in this AJAX handler since it was introduced. I'm surprised no one has noticed it until now! Let's fix it.

#2 @boonebgorges
3 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 11031:

bp-legacy: Group join/leave buttons should have group-button class after AJAX request.

Props dunhakdis.
Fixes #7229.

#3 @dunhakdis
3 years ago

Awesome! Thanks :)

Note: See TracTickets for help on using tickets.