Context Navigation

Changes between Initial Version and Version 1 of Ticket #7227, comment 3

initial	v1
1	1	I have revisited this area of code since working on another patch. `bp_get_default_options()` is getting called on every page load, via `bp_core_set_avatar_constants()`, which causes options to be added if they're missing in the database. See near the "Missing some options, so do some one-time fixing." bit. I'm tempted to remove those fixer lines, because I'm not sure why they are there. Anyone else think it's a good idea?
2	2
3		That aside, for upgrades, `bp_update_to_2_7()` is instantly updating the option with a new key. ~~If we set the key in `bp_core_install_emails()`, it'd be set in `bp_update_to_2_5()`. New installs would have gotten it~~... I'm not sure how, probably working on the assumption that `bp_get_default_options` would run once via `bp_add_options()`.
	3	That aside, for upgrades, `bp_update_to_2_7()` is instantly updating the option with a new key. New installs would have gotten it set via... I'm not sure how, probably working on the assumption that `bp_get_default_options` would run once via `bp_add_options()`.
4	4
5	5	To avoid having to include `pluggable.php`, because i'm worried about causing load-order issues with other plugins that override pluggable function, how about: