Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

#7219 closed enhancement (fixed)

Improve markup of the BuddyPress Tools screen

Reported by: mercime's profile mercime Owned by: mercime's profile mercime
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-screenshots has-patch
Cc:

Description

To do:

1) Combine two fieldsets into one.
2) Remove table layout in fieldset.
3) Add style support.

Attachments (6)

7219.patch (5.6 KB) - added by mercime 8 years ago.
bp-tools-desktop-view.png (56.3 KB) - added by mercime 8 years ago.
Desktop
bp-tools-mobile-view.png (38.1 KB) - added by mercime 8 years ago.
Mobile
7219.1.patch (5.8 KB) - added by mercime 8 years ago.
7219-2nd-patch.png (30.2 KB) - added by mercime 8 years ago.
7219-2nd-mobile.png (19.4 KB) - added by mercime 8 years ago.

Download all attachments as: .zip

Change History (10)

@mercime
8 years ago

@mercime
8 years ago

Desktop

@mercime
8 years ago

Mobile

#1 @mercime
8 years ago

  • Keywords has-screenshots has-patch added

#2 @DJPaul
8 years ago

I'm not sure I agree that each sentence needs to be its own paragraph from a reading-the-words perspective. I think the way it was, plus moving the "Use the tools" to its own paragraph like you've done, is better.

#3 @mercime
8 years ago

Thanks @DJPaul. I agree. The change in wp-admin font from Open Sans to the Windows default font has made reading long lines`difficult. I was going for this layout https://cldup.com/QsGvaTCA9I.png where text is more legible.

Attaching new patch along with screenshots based on your feedback plus some style tweaks: add max-width to the page wrapper and increased line-height for desktop view.

@mercime
8 years ago

#4 @mercime
8 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11014:

Improve markup of the BuddyPress Tools screen.

Make the screen accessible:

  • remove an extra fieldset
  • remove table markup from fieldset
  • improve legibility of long text for desktop

Fixes #7219.

Note: See TracTickets for help on using tickets.