Changes between Initial Version and Version 1 of Ticket #7218, comment 52
- Timestamp:
- 02/02/2018 02:48:57 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #7218, comment 52
initial v1 32 32 4. Not a question, but good catch on `bp_groups_update_orphaned_groups_on_group_delete()` :) 33 33 34 5. `groups_screen_notification_settings()` is not really a screen function, as it doesn't load a template. I'd favor moving it elsewhere, and not treating it with a `Screen` class. 34 5. `groups_screen_notification_settings()` is not really a screen function, as it doesn't load a template. I'd favor moving it elsewhere, and not treating it with a `Screen` class. Same with `bp_ajax_get_suggestions()`. 35 35 36 36 @r-a-y I know that a few of these suggestions require a non-trivial amount of work (especially 1 and 3) so please let me know your thoughts before rushing in. I can help to update the patches if that eases the pain at all :-D