Action "bp_notification_before_save" gets wrong argument

[wordpressrene]

The action "bp_notification_before_save" in the class "BP_Notifications_Notification" in the function "save()" pass the wrong parameter. The data of the notification ($this) is saved in the variable $data before the action. Then the action is called with the parameter $this. After that the notification is stored in the database with the values of $data. So you can't change the data before saving.

[wordpressrene]

I forgot something: to fix this Bug, you just have to change array( &$this ) into array( &$data ) or alternativly you can move the action before the declaration of array( $data ).

[DJPaul]

Yes, good find. I'll move the declaration of $data because I think these filters are intended to filter the current object, not the data being saved.

[djpaul]

In 11015:

Notifications: fix bp_notification_before_save filter being called too late to allow changes to notification.

Fixes #7213

Props wordpressrene

[DJPaul]

Thank you also @wordpressrene for letting us know, I think this is your first BuddyPress contribution! :)