Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#721 closed defect (bug) (fixed)

"selected" class is not removed when changing letter filter [Has Patch]

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: jason_jm's profile Jason_JM
Milestone: 1.1 Priority: minor
Severity: Version: 1.0
Component: Keywords: has-patch
Cc: Jason_JM

Description

When viewing the directory area of the member theme, if you click on a letter, and then click on another letter, the first letter does not lose its "selected" class.

No patch yet, just noticed it now. I think I noticed it before but never filed a ticket for it.

Attachments (3)

(JASON_JM)(MU)directory-blogs_ticket-721(v1).patch​ (866 bytes) - added by Jason_JM 15 years ago.
V1, Patch 1 of 3 Provided.
(JASON_JM)(MU)directory-groups_ticket-721(v1).patch​ (816 bytes) - added by Jason_JM 15 years ago.
V1, Patch 2 of 3 Provided.
(JASON_JM)(MU)directory-members_ticket-721(v1).patch​ (818 bytes) - added by Jason_JM 15 years ago.
V1, Patch 3 of 3 Provided.

Download all attachments as: .zip

Change History (15)

#1 @apeatling
15 years ago

  • Keywords needs-patch added

#2 @(none)
15 years ago

  • Milestone Default Member Theme 1.1 deleted

Milestone Default Member Theme 1.1 deleted

#3 @apeatling
15 years ago

  • Milestone set to 1.0.4

#4 @r-a-y
15 years ago

I don't know how to create patches... but here's a tentative fix:

change line 6 of /bp-core/js/directory-members.js from:

			jQuery("div#members-list-options a").removeClass("selected");

to

			jQuery("#letter-list li a").removeClass("selected");

#5 @r-a-y
15 years ago

Apply the same fix to "/bp-groups/js/directory-groups.js" and "/bp-blogs/js/directory-blogs.js" as well.

Here's some food for thought:
-It would be neater to consolidate a few jQuery .js files and create a consolidated function, the only variations would be to the AJAX response calls.

#6 @apeatling
15 years ago

  • Milestone changed from 1.0.4 to 1.1

Milestone 1.0.4 deleted

#7 @Jason_JM
15 years ago

  • Owner set to Jason_JM
  • Status changed from new to accepted

#8 @Jason_JM
15 years ago

  • Cc Jason_JM added

#9 @Jason_JM
15 years ago

Splitting out this ticket.

721 will stand for the selected issue while a new ticket will be generated for consolidated js.

@Jason_JM
15 years ago

V1, Patch 1 of 3 Provided.

@Jason_JM
15 years ago

V1, Patch 2 of 3 Provided.

@Jason_JM
15 years ago

V1, Patch 3 of 3 Provided.

#10 @Jason_JM
15 years ago

  • Keywords has-patch added; needs-patch removed
  • Added line to remove selected class.
  • Enhanced js to only remove class where it is defined, existing was doing it for all. May speed things up a little on this page when clicking.

Attached 3 patches.

#11 @Jason_JM
15 years ago

  • Summary changed from "selected" class is not removed when changing letter filter to "selected" class is not removed when changing letter filter [Has Patch]

#12 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [1871]) Fixes #721 props Jason_JM

Note: See TracTickets for help on using tickets.