Opened 7 years ago
Closed 7 years ago
#7199 closed defect (bug) (fixed)
The 'new_blog' activity can be deleted when a contributor is removed from the blog
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.6.2 | Priority: | normal |
Severity: | normal | Version: | 2.6.0 |
Component: | Blogs | Keywords: | has-patch dev-feedback commit |
Cc: |
Description
Working on #6026, i've noticed 2 things:
- When a user is removed from the blog, we are deleting twice the activity (in
bp_blogs_remove_blog_for_user()
and inbp_blogs_delete_new_blog_activity_for_site()
- When a contributor is removed from the blog, although he is not the author of the 'new_blog' activity, the 'new_blog' activity is removed.
I think 1. is some code we forgot to remove in 2.6 while moving code specific to the activity component in bp-blogs-activity.php
(see #6937)
About 2. i think it's there for a pretty long time.
See attached patch and unit tests.
Attachments (1)
Change History (6)
This ticket was mentioned in Slack in #buddypress by mercime. View the logs.
7 years ago
Note: See
TracTickets for help on using
tickets.
I haven't tested your tests -- I assume they fail on the trunk without your patch applied -- but the code changes look good to me!