Skip to:
Content

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#7197 closed defect (bug) (fixed)

404 errors when using HHVM on BP 2.6.1.1

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.6.2 Priority: normal
Severity: normal Version: 2.6.0
Component: Core Keywords: has-patch commit
Cc:

Description

There are reports on the forums with BP 2.6.1.1 causing 404 errors when HHVM is used:
https://buddypress.org/support/topic/page-not-found-404-when-trying-to-access-a-member-profile/#post-256546

I'll try to spin up a HHVM instance over the weekend to try and debug the problem. If anyone uses a good vagrant box for HHVM, let me know before I start looking around.

Attachments (1)

7197.01.patch (831 bytes) - added by r-a-y 18 months ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
18 months ago

#1 @r-a-y
18 months ago

  • Keywords has-patch added; needs-testing needs-patch removed

Confirmed on a HHVM install. Testing on HHVM actually revealed a bug in the create_nav_link() functions during the implementation of the new nav API (#6534).

We shouldn't be returning the nav API methods, we should be returning the array items.

Attached patch works on HHVM and non-HHVM installs.

Last edited 18 months ago by r-a-y (previous) (diff)

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


18 months ago

#3 @DJPaul
18 months ago

  • Keywords commit added

LGTM

#4 @DJPaul
18 months ago

Won't have caught this, but i've added experimental support for HHVM into our Travis-CI configuration in r10975

#5 @r-a-y
18 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10979:

Core: Fix 404 errors on single BuddyPress pages when HHVM is in use.

Debugging on a HHVM install revealed a bug with our create nav link
functions during the implementation of the new navigation API. We
shouldn't be returning the nav API methods in the nav link functions; we
should be returning the nav array item instead.

See #6534.

Fixes #7197 (2.6-branch).

#6 @r-a-y
18 months ago

In 10980:

Core: Fix 404 errors on single BuddyPress pages when HHVM is in use.

Debugging on a HHVM install revealed a bug with our create nav link
functions during the implementation of the new navigation API. We
shouldn't be returning the nav API methods in the nav link functions; we
should be returning the nav array item instead.

See #6534.

Fixes #7197 (trunk).

Note: See TracTickets for help on using tickets.