404 errors when using HHVM on BP 2.6.1.1

[r-a-y]

There are reports on the forums with BP 2.6.1.1 causing 404 errors when HHVM is used:
​https://buddypress.org/support/topic/page-not-found-404-when-trying-to-access-a-member-profile/#post-256546

I'll try to spin up a HHVM instance over the weekend to try and debug the problem. If anyone uses a good vagrant box for HHVM, let me know before I start looking around.

[r-a-y]

Confirmed on a HHVM install. Testing on HHVM actually revealed a bug in the create_nav_link() functions during the implementation of the new nav API (#6534).

We shouldn't be returning the nav API methods, we should be returning the array items.

Attached patch works on HHVM and non-HHVM installs.

[DJPaul]

LGTM

[DJPaul]

Won't have caught this, but i've added experimental support for HHVM into our Travis-CI configuration in r10975

[r-a-y]

In 10979:

Core: Fix 404 errors on single BuddyPress pages when HHVM is in use.

Debugging on a HHVM install revealed a bug with our create nav link
functions during the implementation of the new navigation API. We
shouldn't be returning the nav API methods in the nav link functions; we
should be returning the nav array item instead.

See #6534.

Fixes #7197 (2.6-branch).

[r-a-y]

In 10980:

Core: Fix 404 errors on single BuddyPress pages when HHVM is in use.

Debugging on a HHVM install revealed a bug with our create nav link
functions during the implementation of the new navigation API. We
shouldn't be returning the nav API methods in the nav link functions; we
should be returning the nav array item instead.

See #6534.

Fixes #7197 (trunk).