Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7178 closed enhancement (no action required)

split bp-core into core and common packages

Reported by: DJPaul Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

In bp-core, we have a mixture of common functions (templating, email, etc) mixed with the core architecture (our action/filter registration, upgrade functions, etc). bbPress' organisation is slightly more advanced, and has a neat split between the two.

I'd like to split bp-core into bp-common and bp-core.

Change History (3)

#1 @boonebgorges
3 years ago

Is this mainly for code organization, or does it affect dependencies? Would there be cases in which core was loaded but not common, or vice versa? (Asking mainly for clarification - seems fine to do either way.)

Be sure to use svn cp for this so we don't lose history :-D

#2 @DJPaul
3 years ago

Organisation. Probably would have to whitelist "common" in the same places we whitelist "core' (i.e. autoloader). Both would always be loaded. Common would not show up in the Component list, for example.

#3 @DJPaul
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

This ended up being non-trivial because I couldn't decide whether to make "common" its own Component, or have it just be an empty folder, and if so, how to load it all, etc.

I guess we'll look at this in the future if there's more enthusiasm.

Note: See TracTickets for help on using tickets.