Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#7150 closed defect (bug) (fixed)

The blogs component & the bp_core_add_page_mappings() function

Reported by: imath Owned by: imath
Milestone: 2.7 Priority: normal
Severity: normal Version: 1.7
Component: Settings Keywords: has-patch commit
Cc:

Description

So although the Blogs component is a core/built in component, it's the only one that doesn't have his WordPress directory page set on activation when using a multisite configuration.

First, it's really annoying, and i see no reason for such a treatment.
Second, it can make test fails, eg if you do:

$this->go_to( bp_get_blogs_directory_permalink() );
$this->assertTrue( bp_is_blogs_directory() );

It will fail.

Third, and most importantly bp_core_add_page_mappings() is using "sites" instead of "blogs" which is THE reason why the page is not created when creating the blogs component.

In 2.7, i'd really like to give some love to this component, and the attached patch is the first proof of my love :)

Attachments (1)

7150.patch (3.1 KB) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (4)

@imath
3 years ago

#1 @r-a-y
3 years ago

Nice catch, imath!

Looks good.

#2 @DJPaul
3 years ago

  • Keywords commit added

LGTM

#3 @imath
3 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10972:

Multisite: Make sure the Blogs directory page is dynamically created when activating the component.

Fixes #7150

Note: See TracTickets for help on using tickets.