Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7114


Ignore:
Timestamp:
06/09/2016 05:55:15 PM (4 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7114

    • Property Summary changed from XProfile: Do not duplicate caching logic in BP_XProfile_Field to XProfile: Do not duplicate populate logic in BP_XProfile_Field
  • Ticket #7114 – Description

    initial v1  
    1 While debugging #7112, I saw some duplicate caching logic that we can remove.
     1While debugging #7112, I saw some duplicate DB logic that we can remove.
    22
    3 See attached patch.
     3The $wpdb->get_row() call is duplicated in both `BP_XProfile_Field::populate()` and `BP_XProfile_Field::get_instance()` DB methods.
     4
     5Attached patch merges the logic into the `populate()` method and passes existing unit tests.