Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7105, comment 9


Ignore:
Timestamp:
08/24/2016 04:03:54 PM (8 years ago)
Author:
dcavins
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7105, comment 9

    initial v1  
    33* Change structure of list items to more closely match `members/members-loop.php` as suggested by @r-a-y. (Should we be also updating `groups/single/members.php` to be more like that?)
    44* Added the action `bp_group_manage_members_admin_item` to the admin and moderator list items. (Already was applied to the member list.)
    5 * Added “none found” messages for each loop to support the addition of a search box in #6835.
     5* Added “none found” messages for each loop to support the addition of a search box in #6385.
    66
    77I thought more about using  `bp_groups_has_members()` instead of `bp_has_members()` for the admin and mod loops, and, while I'm not assuming we'll go that direction, there are some advantages. If we used `bp_groups_has_members()` for the loops, we could also then use  `bp_group_member_joined_since()` (which seems useful) and easily add pagination when necessary to the admin and mod loops via `bp_group_member_needs_pagination()`.