Invalid array data inside bp_attachments_uploads_dir_get()

[tw2113]

In the bp_attachments_uploads_dir_get function, we attempt to iterate over $upload_data. However, that variable is only created via return value from bp_upload_dir() which only returns a string. Because of this, there will never be a valid value to do a foreach over.

[imath]

I think it's a docblock issue. bp_upload_dir() returns an associative array having these keys:

• 'path' - base directory and sub directory or full path to upload directory.
• 'url' - base url and sub directory or absolute URL to upload directory.
• 'subdir' - sub directory if uploads use year/month folders option is on.
• 'basedir' - path without subdir.
• 'baseurl' - URL path without subdir.
• 'error' - false or error message.

That's because bp_upload_dir() is simply the result of wp_upload_dir() for the root blog id

[tw2113]

Looking over things, I believe @imath is likely correct overall. bp_upload_dir() is going to be either bool or array, and we return early in bp_attachments_uploads_dir_get() if false.

Going to make it a return type fix ticket instead.

[tw2113]

Adding to 2.7. It's a docs fix.

[tw2113]

In 11088:

Fixes phpdoc for bp_upload_dir return type. Fixes #7097.