Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#7090 closed enhancement (fixed)

Accessibility: Remove redundant `title` attributes

Reported by: mercime's profile mercime Owned by: mercime's profile mercime
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch has-screenshots commit
Cc:

Description

"For users of assistive technologies, the title attribute is useless at best and sometimes an annoyance. Users of text-to-speech software who have configured their software to do so will hear the title attribute twice. Essentially the extensive use of title attributes throughout Wordpress Core amounts to unnecessary code bloat." ~ Karl Groves

See ​WP#24766 which started the ball rolling in the removal of title attributes from within the WordPress admin and from the latest WP Default themes.

Upcoming patch removes the following title attributes:

  • title="Create a Group" for: Create a Group
  • title="Join Group" for: Join Group
  • title="Leave Group" for: Leave Group
  • title="Request Membership" for: Request Membership
  • title="Request Sent" for: Request Sent
  • title="Accept Invitation" for: Accept Invitation
  • title="Delete Group Profile Photo" for: Delete Group Profile Photo
  • title="Delete Cover Image" for: Delete Group Cover Image
  • title="Kick and Ban this member" for: Kick and Ban
  • title="Promote to Mod" for: Promote to Mod
  • title="Promote to Admin" for: Promote to Admin
  • title="Remove this member" for: Remove from group
  • title="New Topic" for: New Topic
  • title="Accept" for: Accept
  • title="Reject" for: Recent
  • title="Add Friend" for: Add Friend
  • title="Cancel Friendship Request" for: Cancel Friendship Request
  • title="Cancel Friendship Requested" for: Cancel Friendship
  • title="Friendship Requested" for: Friendship Requested
  • title="Delete Profile Photo" for: Delete My Profile Photo
  • title="Delete Cover Image" for: Delete My Cover Image
  • title="Edit Profile" for: Edit Profile
  • title="Mark as Favorite" for: Favorite
  • title="Remove Favorite" for: Remove Favorite
  • title="View Message" for: View Message
  • title="This field's visibility cannot be changed." for: text which is not a link in the Settings > Profile Visibility screen
  • title="Send a Public Message on your Activity Stream" for: Public Message
  • title="Send a Private Message to this User" for: Private Message
  • title="The public activity for Everyone on this site" for Sitewide Activity navigation: All Members
  • title="The activity of my friends only" for Sitewide Activity navigation: My Friends
  • title="The activity of groups I am a member of" for Sitewide Activity navigation: My Groups
  • title="The activity I've marked as favorite" for Sitewide Activity navigation: My Favorites
  • title="Activity that I have been mentioned in" for Sitewide Activity navigation: Mentions
  • title="Create a Site" for: Create a Site
  • title="Visit Site" for: Visit Site

NOT included in the list above:

  • title="RSS Feed" for: RSS
  • title="Star the first message in this thread" for: the star icon
  • title="Remove all starred messages in this thread" for: the star icon
  • title="View Discussion" for: activity post timestamp a.k.a activity permalink
  • title attributes for all Avatars and member and group links, etc. -> separate trac ticket
  • title attributes in BP wp-admin screens -> to be addressed in audit of BP admin screens

Patch coming up.

Attachments (2)

7090.patch​ (28.5 KB) - added by mercime 9 years ago.
7090.2.patch​ (28.9 KB) - added by mercime 9 years ago.
Refreshed patch

Download all attachments as: .zip

Change History (10)

@mercime
9 years ago

#1 @mercime
9 years ago

  • Keywords has-screenshots added

1st batch:
https://cldup.com/Ld_fCOQgmG.png

2nd batch:
https://cldup.com/7d86CoPHDH.png

3rd batch:
https://cldup.com/KrIclCHc46.png

Last edited 9 years ago by mercime (previous) (diff)

#2 @DJPaul
9 years ago

  • Component changed from General - UX/UI to Core

#3 @DJPaul
9 years ago

  • Milestone changed from Awaiting Review to 2.7

@mercime Don't leave your own tickets in Awaiting Review when they're this straightforward. They miss releases. :)

#4 @DJPaul
9 years ago

  • Keywords commit added

@mercime I suggest you get this in as soon as possible - part of the patch already doesn't apply, but the bulk still does (just about!).

#5 @mercime
9 years ago

@DJPaul Thank you. I will refresh the patch and upload it here before committing.

@mercime
9 years ago

Refreshed patch

#6 @mercime
9 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10904:

Accessibility: Remove redundant title attributes.

This is the first sweep for removing title attributes from the
BuddyPress template files.

Fixes #7090.

#7 @hnla
9 years ago

@mercime while it's true that the title attribute should never just be used to repeat stuff already conveyed in text, it is used where it helps to add additional detail to clarify, on that basis some instances such as activity in which I have been mentioned in might help to expand on a possibly vague link text 'mentions'?

Most of these title examples are pretty redundant though!

#8 @mercime
9 years ago

@hnla see ​https://buddypress.trac.wordpress.org/ticket/7188 to address additional details needed.

Note: See TracTickets for help on using tickets.