Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7087 closed enhancement (fixed)

WIdgets: Enqueue scripts on `'wp_enqueue_scripts'` hook

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.6 Priority: normal
Severity: normal Version: 1.0
Component: Core Keywords: has-patch
Cc:

Description

In our widgets that contain enqueued JS, we currently do not hook the JS on 'wp_enqueue_scripts'.

We should do this to avoid enqueuing too early and to also remove checks on admin pages.

Attachments (1)

7087.01.patch (3.3 KB) - added by r-a-y 4 years ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
4 years ago

#1 @imath
4 years ago

Patch looks good, why not hooking to bp_enqueue_scripts ?

#2 @r-a-y
4 years ago

Patch looks good, why not hooking to bp_enqueue_scripts ?

Good call! Will make the change and commit.

#3 @r-a-y
4 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10809:

Widgets: Enqueue JS on 'bp_enqueue_scripts' action.

Previously, we were enqueuing our JS too early resulting in our JS being
loaded on embed pages.

Fixes #7087.

#4 @DJPaul
4 years ago

  • Component changed from API - WordPress to Core
Note: See TracTickets for help on using tickets.