I18n: make XProfile admin js text nodes translatable

[Offereins]

In bp-xprofile/admin/js/admin.js the add_option function creates text nodes with untranslated strings:

txt1         = document.createTextNode( 'Default Value' ),
toDeleteText = document.createTextNode( 'Delete' ),

Is there any reason why these are not translatable? Can we use wp_localize_script() here?

[DJPaul]

Yes. It hasn't been done probably because we haven't noticed because this file is written with a distinct JS style that wasn't replicated anywhere else in BuddyPress (this was written probably six years ago).

The file is isolated enough to be re-written with better JS standards and we can absolutely make the string translatable then.

[Offereins]

#7413 was marked as duplicate.

[imath]

Hi @slaFFik

Patch looks good. Thanks for your work on it. I'd just suggest to align the array items according to WPCS, this way:

'default_value' => __( 'Default Value', 'buddypress' ),
'delete'        => __( 'Delete', 'buddypress' ),

We'll include this fix into 8.0.0 as it's not a regression from 7.0.0. Feel free to commit it in trunk 👍

[slaFFik]

I haven't aligned this array because other items in this same array are not aligned, I've just preserved the code style that's already in the file.
I will update the patch (will apply same formating for the whole array) and will push it to the trunk.
Thanks.

[slaffik]

In 12828:

XProfile: make admin js text nodes translatable

Certain user-facing strings added in the XProfile admin area using JavaScript were not translatable. We moved them to PHP and injected in JS using wp_localize_scripts().

Fixes #7076 (trunk).

[slaffik]

In 12829:

XProfile: make admin js text nodes translatable

Fix JS issues reported by the jshint, convert to camel case.

See #7076 (trunk).