Skip to:
Content

BuddyPress.org

Opened 3 years ago

Last modified 3 years ago

#7076 new defect (bug)

I18n: make XProfile admin js text nodes translatable

Reported by: Offereins Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: I18N Keywords: needs-patch
Cc: lmoffereins@…

Description

In bp-xprofile/admin/js/admin.js the add_option function creates text nodes with untranslated strings:

txt1         = document.createTextNode( 'Default Value' ),
toDeleteText = document.createTextNode( 'Delete' ),

Is there any reason why these are not translatable? Can we use wp_localize_script() here?

Change History (3)

#1 @DJPaul
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Yes. It hasn't been done probably because we haven't noticed because this file is written with a distinct JS style that wasn't replicated anywhere else in BuddyPress (this was written probably six years ago).

The file is isolated enough to be re-written with better JS standards and we can absolutely make the string translatable then.

#2 @DJPaul
3 years ago

  • Component changed from Locale - i18n to I18N

#3 @Offereins
3 years ago

#7413 was marked as duplicate.

Note: See TracTickets for help on using tickets.