Skip to:
Content

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#7067 closed defect (bug) (fixed)

Notifications: Notification meta doesn't work

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.6 Priority: high
Severity: major Version: 2.3.0
Component: Toolbar & Notifications Keywords: has-patch
Cc:

Description

In #6257, we introduced notification meta.

However, it doesn't work at all!

Attached patch fixes notification meta and adds a unit test.

Attachments (1)

7067.01.patch (5.8 KB) - added by r-a-y 20 months ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
20 months ago

#1 @imath
20 months ago

Ouch! Patch looks good. Thanks a lot for finding/solving this issue

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


20 months ago

#3 @r-a-y
20 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10788:

Notifications: Make notification meta great again.

This commit fixes this for the betterment of notifications everywhere.

Fixes #7067.

#4 @r-a-y
20 months ago

In 10789:

Notifications: Update meta cache in BP_Notifications_Notification::get().

We update the meta cache if update_meta_cache is true, which it is by
default. Commit also updates the DocBlock to outline a few missing
parameters.

See #6257, #7067.

Note: See TracTickets for help on using tickets.