Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#7062 closed defect (bug) (fixed)

Test related to `bp_options_nav` backcompat and `bp_core_remove_nav_item()` failing

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Navigation Keywords:
Cc:

Description

1) BP_Tests_Core_Nav_BpCoreRemoveNavItem::test_should_remove_subnav_items
Undefined index: foo

/var/www/core.wordpress.pv/wordpress/src/wp-content/plugins/buddypress/src/bp-core/classes/class-bp-core-bp-options-nav-backcompat.php:63
/var/www/core.wordpress.pv/wordpress/src/wp-content/plugins/buddypress/tests/phpunit/testcases/core/nav/bpCoreRemoveNavItem.php:37

See #6534. Introduced in [10745].

The failure doesn't happen on PHP 7.

Change History (2)

#1 @boonebgorges
4 years ago

  • Owner changed from imath to boonebgorges
  • Status changed from new to assigned

#2 @boonebgorges
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 10752:

Nav backcompat: Check the existence of an offset before fetching it.

Helps avoid PHP notices when accessing the bp_options_nav backcompat layer
after calling bp_core_remove_nav_item().

The error only appears when running versions of PHP earlier than 7.0, which is
why it was inadvertently introduced in [10745]. See #6534.

Fixes #7062.

Note: See TracTickets for help on using tickets.