Skip to:
Content

#7049 closed defect (bug) (fixed)

xprofile_updated_profile actions pass different args

Reported by: nickmomrik Owned by: dcavins
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.0
Component: Extended Profile Keywords: has-patch commit
Cc:

Description

When updating an extended profile from inside wp-admin, the xprofile_updated_profile action doesn't pass all of the args, namely the $old_values & $new_values which were fixed in #5755 for front-end profile updates. I took from that same code for the attached patch, also rearranging to match so visibility values could be passed in the old/new values as well.

Attachments (2)

admin-xprofile_updated_profile.diff (3.2 KB) - added by nickmomrik 21 months ago.
7049.02.diff (3.6 KB) - added by dcavins 20 months ago.
Update the action 'xprofile_updated_profile' in BP_XProfile_User_Admin::user_admin_load() to pass the same parameters as the same action in xprofile_screen_edit_profile().

Download all attachments as: .zip

Change History (6)

#1 @johnjamesjacoby
21 months ago

  • Keywords early commit added
  • Milestone changed from Awaiting Review to 2.6

Nice find!

Thanks for the patch. At a cursory, this looks good to me.

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


20 months ago

@dcavins
20 months ago

Update the action 'xprofile_updated_profile' in BP_XProfile_User_Admin::user_admin_load() to pass the same parameters as the same action in xprofile_screen_edit_profile().

#3 @dcavins
20 months ago

  • Keywords early removed

Thanks for the patch! I've updated it slightly to adhere to comment styling and such.

For those just tuning in, the action xprofile_updated_profile() was called in two places:
BP_XProfile_User_Admin::user_admin_load() & xprofile_screen_edit_profile() with different passed parameters. The ticket author's fix is to harmonize the two functions, which is a great improvement.

#4 @dcavins
20 months ago

  • Owner set to dcavins
  • Resolution set to fixed
  • Status changed from new to closed

In 10822:

Harmonize parameters sent with xprofile_updated_profile action.

Update the action xprofile_updated_profile
in BP_XProfile_User_Admin::user_admin_load()
so that the same parameters are passed as
when the when the same action occurs in
xprofile_screen_edit_profile().

Fixes #7049.

Props nickmomrik.

Note: See TracTickets for help on using tickets.