Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7033 closed defect (bug) (fixed)

Change email notification is broken

Reported by: slaFFik Owned by: djpaul
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Settings Keywords:
Cc: oksankaa

Description (last modified by slaFFik)

When on this page: /members/slaffik/settings/ try to change your email.
On success it shows:

There is a pending change of your email address to new@email.com.	
Check your email (new@email.com) for the verification link, or cancel the pending change.

While it should be:

There is a pending change of your email address to new@email.com.	
Check your email (old@email.com) for the verification link, or cancel the pending change.

Change History (7)

#1 @slaFFik
4 years ago

  • Description modified (diff)

#2 @slaFFik
4 years ago

Initially found by @oksankaa. She didn't have an account, so I created issues on her behalf.

#3 @slaFFik
4 years ago

  • Cc oksankaa added

#4 @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to 2.6

#5 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10716:

Emails: when someone changes their email, tell users we've sent confirmation to their current (old) address, not the new one.

Clarifies the intent of the original message in this UI notification.

Fixes #7033

Props @oksankaa

#6 @DJPaul
4 years ago

I forgot to note a fix I included in the same commit, in the previous commit message. Sorry.

There are two printf placeholders in this string, they were "%1$s" and "%s". Unfortunately, that second one is functionally identical to the first, so the URL (to dismiss the notification) was never being constructed properly. I switched it to "%2$s" to fix.

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.