Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7024, comment 7


Ignore:
Timestamp:
04/20/2016 10:42:40 PM (4 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7024, comment 7

    initial v1  
    11https://github.com/paulgibbs/BuddyPress/commit/2a621518d4f2eb39c848c2b96999e952b853fefe was the commit for this during development.
    22
    3 As things stand, we use the site name (option `blogname`) for the default value of the "From name" property.  When you set `blogname` in WordPress, it's sanitized with `esc_html` via `sanitize_option` before being stored in the database. Email from/reply to/bbc/cc "names" should not be HTML escaped otherwise you can end up with odd-looking values in the email, which in my testing sometimes caused deliverability issue.
     3As things stand, we use the site name (option `blogname`) for the default value of the "From name" property.  When you set `blogname` in WordPress, it's sanitized with `esc_html` via `sanitize_option` before being stored in the database. Email from/reply to/to/bbc/cc "names" should not be HTML escaped otherwise you can end up with odd-looking values in the email, which in my testing sometimes caused deliverability issue.
    44
    55In this patch, as we've fixed `wp_mail_from_name` support for your edge case (IMO - it wasn't a use case I had considered during development), I figured falling back to use its default value of "WordPress" rather than `blogname` made sense for consistency with `wp_mail`.