EXIF Orientation Handling Extraneous

[andrewgtibbetts]

This is a follow-up to #5089.
WP 4.5 now keeps EXIF data ( ​https://core.trac.wordpress.org/changeset/36891 ).
So, it seems the work done in 5089 ( ​https://buddypress.trac.wordpress.org/changeset/10178 ) now breaks image orientation.

[r-a-y]

So, it seems the work done in 5089 now breaks image orientation.

Can someone verify that WordPress 4.5 indeed breaks the image orientation support we added in #5089? Our unit test created for orientation - test_bp_attachment_get_image_data() - does not fail.

It looks like WP's changeset only works if Imagick is used. Not sure if that's what BuddyPress uses as well.

Also since BP 2.6 will require WP 4.1, perhaps we can remove our older WP 3.9 backward compatibility checks for orientation.

[imath]

I've checked 2 days ago with an image needing to be rotated and i confirm it worked as expected. And i agree about the backward compatibility check

[DJPaul]

@imath Are you saying WP 4.5 broke BuddyPress' image rotating support? Or, that we can remove our code because WordPress will now fix it for us?

[imath]

@DJPaul no, i'm saying the opposite. Unlike what @andrewgtibbetts reported, last time i've checked we kept on needing what we have today in trunk.

[DJPaul]

Neat.