Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#7019 closed defect (bug) (worksforme)

EXIF Orientation Handling Extraneous

Reported by: andrewgtibbetts Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.5.0
Component: Media Keywords: needs-unit-tests reporter-feedback
Cc:

Description

This is a follow-up to #5089.
WP 4.5 now keeps EXIF data ( https://core.trac.wordpress.org/changeset/36891 ).
So, it seems the work done in 5089 ( https://buddypress.trac.wordpress.org/changeset/10178 ) now breaks image orientation.

Change History (7)

#1 @andrewgtibbetts
3 years ago

  • Summary changed from EXIF Orientation Handling Extraneous? to EXIF Orientation Handling Extraneous

#2 @r-a-y
3 years ago

  • Keywords reporter-feedback added

So, it seems the work done in 5089 now breaks image orientation.

Can someone verify that WordPress 4.5 indeed breaks the image orientation support we added in #5089? Our unit test created for orientation - test_bp_attachment_get_image_data() - does not fail.

It looks like WP's changeset only works if Imagick is used. Not sure if that's what BuddyPress uses as well.

Also since BP 2.6 will require WP 4.1, perhaps we can remove our older WP 3.9 backward compatibility checks for orientation.

#3 @imath
3 years ago

I've checked 2 days ago with an image needing to be rotated and i confirm it worked as expected. And i agree about the backward compatibility check

#4 @DJPaul
3 years ago

  • Milestone changed from Awaiting Review to Under Consideration

@imath Are you saying WP 4.5 broke BuddyPress' image rotating support? Or, that we can remove our code because WordPress will now fix it for us?

#5 @imath
3 years ago

@DJPaul no, i'm saying the opposite. Unlike what @andrewgtibbetts reported, last time i've checked we kept on needing what we have today in trunk.

#6 @DJPaul
3 years ago

  • Milestone Under Consideration deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Neat.

#7 @DJPaul
3 years ago

  • Component changed from Component - Attachments to Media
Note: See TracTickets for help on using tickets.