Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7009, comment 3


Ignore:
Timestamp:
04/11/2016 07:43:05 PM (9 years ago)
Author:
singhleo
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7009, comment 3

    initial v1  
    66after doing more deep debug. i found the victim.
    77
    8 multisite code is fine it has nothing wrong in it which is.
     8multisite code is fine it has nothing wrong in it, which is.
    99{{{#!php
    1010<?php
     
    1414}}}
    1515
    16 So what it doing it setting the sub site subdomain to the host. and mail uses host for right hand part of message id header info.
     16So what it doing it setting the sub site subdomain to the host. and phpmailer uses it for message id header info right hand part.
     17eg. message-id@host
    1718
    18 and what we are doing in buddypress for mail functionality is.
     19and what we are doing in BuddyPress for mail functionality is.
    1920
    2021{{{#!php
     
    3031
    3132So from above code.
     33
    3234return get_current_site()->domain;  // From fix_phpmailer_messageid() <-- this line is correct which is taken from multisite setup.
    3335
    34 But this line is wrong.
     36But problem is with this line.
    3537return preg_replace( '#^https?://#i', '', bp_get_option( 'home' ) );
    3638
    37 which is returning sub site url with sub paths instead of host.
     39which is returning sub site url with sub paths (eg. domain.com/subsite1) instead of host (eg, domain.com).
    3840as host name cannot contain the subsite directory and http://. and in most cases its subsite.
    3941
     
    4850subsite1.domain.com
    4951
    50 So in BuddyPress that function code should be changed to something..
     52So in BuddyPress mail api that function code should be changed to something..
    5153
    5254{{{#!php