Skip to:
Content

Opened 10 years ago

Closed 9 years ago

Last modified 8 years ago

#699 closed defect (bug) (fixed)

BuddyPress Navs should be in a own hook + diff

Reported by: nicolagreco Owned by: nicolagreco
Milestone: 1.2 Priority: minor
Severity: normal Version:
Component: Core Keywords: has-patch nicolagreco
Cc:

Description

As you can see in the diff file, i moved all setup_nav actions in from wp to bp_nav.

I'm working on mediawiki integration, and to no nav items are added if there isnt any call to 'wp' action ( like do_action('wp')), so i can't load $bp->bp_nav items without loading all wp environment (things that i don't want)

So if there is a new functions ( the bp_core_setup_navs in the diff ) that loads the global without loading 'wp'

so with that i can have $bp->bp_nav adding do_action( 'bp_nav' ) or using directly bp_core_setup_navs.

The same should be done for setup_globals

Attachments (1)

bp_core_setup_navs.patch (3.5 KB) - added by nicolagreco 10 years ago.

Download all attachments as: .zip

Change History (10)

#1 @apeatling
10 years ago

  • Milestone changed from Core 1.0 to Core 1.1

#2 @(none)
10 years ago

  • Milestone Core 1.1 deleted

Milestone Core 1.1 deleted

#3 @nicolagreco
10 years ago

  • Milestone set to 1.1

#4 @apeatling
10 years ago

  • Milestone changed from 1.1 to 1.2

#5 @johnjamesjacoby
9 years ago

I will +1 this if anything because it looks cleaner in the code to not hook all of the navs in two different places. :)

#6 @DJPaul
9 years ago

  • Priority changed from major to minor

#7 @apeatling
9 years ago

  • Milestone changed from 1.2 to Future Release

#8 @cnorris23
9 years ago

  • Component set to Core
  • Resolution set to fixed
  • Status changed from new to closed

This was done in [2656], and is currently in 1.2+ in the form of 'bp_setup_nav'. It's also been removed from the 'wp' and 'admin_menu' hooks, and moved to 'plugins_loaded'.

#9 @johnjamesjacoby
8 years ago

  • Keywords changed from has-patch, nicolagreco to has-patch nicolagreco
  • Milestone changed from Future Release to 1.2
  • Severity set to normal
  • Version 1.0 deleted

Moving closed ticket out of Future Release.

Note: See TracTickets for help on using tickets.