bp_core_print_generation_time() should echo only in WP_DEBUG mode

[slaFFik]

Currently bp_core_print_generation_time() prints info like this:

<!-- Generated in 0,608 seconds. (103 q) -->

on every page load.

I believe, that's quite sensitive information, and should NOT be printed in normal mode.

WP_DEBUG is more appropriate situation.

Also, I think we need to increase the $priority to something like 9999 or bigger, as wp_footer is rather popular action.

[DJPaul]

Nah, let's just kill it. It's so old it was probably used as a way of measuring performance during initial development.

[slaFFik]

There IS a difference in data, when we have 9999 priority (both in queries and seconds). Between 10 and 9999 - 8 queries, 10 and 99999 - 10 queries.

And I do want to preserve it :) So can I submit a patch that will preserve it and display in DEBUG mode only?

[slaFFik]

Better submit than not :)

[DJPaul]

Let's decide in dev chat whether to keep this with slaFFik's patch or just remove it entirely (my preference).

[boonebgorges]

Let's decide in dev chat whether to keep this with slaFFik's patch or just remove it entirely (my preference).

Let's just decide now. Out it goes :)

@slaFFik - I can see why it'd be useful to have data during WP_DEBUG, but a BP core function doesn't seem like the appropriate place. A proper debugging tool should be used. May I suggest ​https://wordpress.org/plugins/query-monitor/ ?

[slaFFik]

And Debug Bar displays that info too (with SAVEQUERIES defined). This small comment with sec and q was used by me for 7 years, it's like an old good friend :)

But I totally understand Paul's and your idea. So just remove it completely. Perhaps this will save some CPU for servers out there :)

[boonebgorges]

In 10723:

Deprecate bp_core_print_generation_time().

Props slaFFik.
Fixes #6976.