Params for bp_get_activity_content_body filter should be the same whatever the context

[imath]

In bp-activity-template.php it's :
apply_filters_ref_array( 'bp_get_activity_content_body', array( $activities_template->activity->content, &$activities_template->activity ) )

2 arguments: the content + the full activity object

In bp-legacy/buddypress-functions.php it's
apply_filters( 'bp_get_activity_content_body', $activity->content )

1 argument the content only

In bp-activity-notifications.php it's
apply_filters( 'bp_get_activity_content_body', $params['content'] ); `

1 argument the content only

And in class-bp-activity-list-table.php it's
apply_filters_ref_array( 'bp_get_activity_content_body', array( $item['content'] ) )

1 argument the content only.

As soon as you only need the content, it's ok. But if you need the full activity object to check for additional properties, it's a nightmare!

The filter should always include 2 params imho.

[r-a-y]

Passing both parameters sounds good to me, imath!

[Offereins]

Definitely something I'd like to see fixed for 2.8! I'll have it on my list.

[sanket.parmar]

I have added an activity object as a second parameter at all the places where bp_get_activity_content_body filter is applied.

[boonebgorges]

@sanket.parmar Thanks for the patch! Because the "primary" instance of the filter passes the activity object by reference, we should do the same thing in every instance. In some cases, this means we'll have to switch to apply_filters_ref_array().

[boonebgorges]

In 11351:

bp_get_activity_content_body filter should receive same params in all contexts.

This changeset makes all instances of bp_get_activity_content_body
consistent by ensuring that they all receive the activity object
as a second parameter. This requires switching to apply_filters_ref_array(),
so that the second param can always be passed by reference.

Props sanket.parmar.
Fixes #6971.

[sanket.parmar]

Hi @boonebgorges

Should I replace with apply_filters_ref_array() for all the occurrences?

[boonebgorges]

@sanket.parmar No need, I have taken care of it in [11351]. Thanks for the patch!

[sanket.parmar]

Hi @boonebgorges

Thank you :)