Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6969, comment 2


Ignore:
Timestamp:
03/21/2016 08:36:37 PM (6 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6969, comment 2

    initial v1  
    33Bug occurs when a numeric string is passed to `BP_Email_Recipient` instead of an integer.
    44
     5The `$initiator_id` in `friends_notification_accepted_request()` uses a numeric string, which is why the email fails to send because no recipient is parsed correctly in `BP_Email_Recipient`.
     6
    57I suggest patching `BP_Email_Recipient` to use `is_numeric()` instead of `is_int()` to fix this problem.  A broader solution would be to audit all our access methods and functions to ensure that numeric strings are cast as integers or to use `is_numeric()` where needed.