Skip to:
Content

BuddyPress.org

Opened 4 years ago

Last modified 21 months ago

#6965 assigned enhancement

"emails in the wrong language" notice should be dismissable

Reported by: slaFFik Owned by: DJPaul
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: Emails Keywords:
Cc:

Description

As admin might already did that. Or he doesn't need it at all (like for en_CA, en_AU, en_NZ etc).

Or we can add it as a Help section (Contextual help, or how is it called), so it will be not so intrusive and too eye-catching.

See bp_admin_email_maybe_add_translation_notice() for reference.

Change History (9)

#1 @slaFFik
4 years ago

  • Summary changed from "emails in the wrong language" should be dismissable to "emails in the wrong language" notice should be dismissable

#2 @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to Future Release

My opinion is that no-one would ever see it if we hid in the Contextual Help tab.

#3 @DJPaul
3 years ago

Are you still keen on this being a dismissible notice, @slaFFik? Do we care about the idea of a site language switching multiple times?

This certainly gets complicated now WordPress 4.7(?) supports per-user languages inside wp-admin. Perhaps we could revisit the wording and try to re-phrase it so it is clearer it relates to the site language, not the user's language (we should probably update the logic for this, I bet it's "broken").

#4 @slaFFik
3 years ago

  • Milestone changed from Future Release to 2.8

That would be a whole new big problem, if we wanted to support WP4.7 feature of per-user language. So I would go with a rephrase tactic for now. So instead of:

Are your emails in the wrong language? Go to <a href="%s">BuddyPress Tools and run the "reinstall emails"</a> tool.

We can have something like:

Are your emails in not the site language? Go to <a href="%s">BuddyPress Tools and run the "reinstall emails"</a> tool.

It's pre-WP4.7 safe, so should be fine.

#5 @DJPaul
3 years ago

  • Milestone changed from 2.8 to Future Release

#6 @DJPaul
21 months ago

  • Milestone changed from Awaiting Contributions to 3.0
  • Owner set to DJPaul
  • Status changed from new to assigned

#7 @djpaul
21 months ago

In 11892:

Emails: reword "emails in the wrong language" notice.

Make it clearer we are referring to the site language, not the user's language.

See #6965

#8 @DJPaul
21 months ago

We should still make this notice dismissible. Would be easier if WP had an API for this?

#9 @DJPaul
21 months ago

  • Milestone changed from 3.0 to Awaiting Contributions
Note: See TracTickets for help on using tickets.