Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#6964 closed defect (bug) (fixed)

Not translatable components names in dropdown of Activity admin area

Reported by: slaFFik Owned by: djpaul
Priority: normal Milestone: 2.7
Component: I18N Version:
Severity: normal Keywords: good-first-bug needs-patch
Cc:

Description

On this page /wp-admin/admin.php?page=bp-activity there is a dropdown of all actions (see attached).
But because of this code (in BuddyPress 2.5.1):

// see: /plugins/buddypress/bp-activity/classes/class-bp-activity-list-table.php::423
<optgroup label="<?php echo ucfirst( $component ); ?>">

those section names are not translatable.

Attachments (1)

2016-03-17_1322.png (73.8 KB ) - added by slaFFik 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @slaFFik
10 years ago

  • Component Component - ActivityLocale - i18n

According to the way components are loading - all of them have a component name:

parent::start(
	'activity',
	__( 'Activity Streams', 'buddypress' ),
	buddypress()->plugin_dir,
	array(
		'adminbar_myaccount_order' => 10,
		'search_query_arg' => 'activity_search',
	)
);

So why not to use here those $name string?

#2 @DJPaul
10 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone Awaiting ReviewFuture Release

#3 @DJPaul
10 years ago

  • Component Locale - i18nI18N

#4 @djpaul
10 years ago

  • Owner set to djpaul
  • Resolutionfixed
  • Status newclosed

In 10961:

Activity: fix un-translatable strings in the wp-admin management screen.

Fixes #6964

#5 @DJPaul
10 years ago

  • Milestone Future Release2.7
Note: See TracTickets for help on using tickets.