Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#6964 closed defect (bug) (fixed)

Not translatable components names in dropdown of Activity admin area

Reported by: slaFFik Owned by: djpaul
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: I18N Keywords: good-first-bug needs-patch
Cc:

Description

On this page /wp-admin/admin.php?page=bp-activity there is a dropdown of all actions (see attached).
But because of this code (in BuddyPress 2.5.1):

// see: /plugins/buddypress/bp-activity/classes/class-bp-activity-list-table.php::423
<optgroup label="<?php echo ucfirst( $component ); ?>">

those section names are not translatable.

Attachments (1)

2016-03-17_1322.png (73.8 KB) - added by slaFFik 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @slaFFik
4 years ago

  • Component changed from Component - Activity to Locale - i18n

According to the way components are loading - all of them have a component name:

parent::start(
	'activity',
	__( 'Activity Streams', 'buddypress' ),
	buddypress()->plugin_dir,
	array(
		'adminbar_myaccount_order' => 10,
		'search_query_arg' => 'activity_search',
	)
);

So why not to use here those $name string?

#2 @DJPaul
4 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone changed from Awaiting Review to Future Release

#3 @DJPaul
3 years ago

  • Component changed from Locale - i18n to I18N

#4 @djpaul
3 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10961:

Activity: fix un-translatable strings in the wp-admin management screen.

Fixes #6964

#5 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.7
Note: See TracTickets for help on using tickets.