Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 10 years ago

Last modified 7 years ago

#6962 closed defect (bug) (fixed)

Profile Cover not working when we define a custom BP_XPROFILE_SLUG

Reported by: Maniou Owned by: r-a-y
Priority: normal Milestone: 2.6
Component: Media Version: 2.4.0
Severity: normal Keywords: has-patch commit
Cc:

Description

Hello,

When we define a custom BP_XPROFILE_SLUG for example : 

define ( 'BP_XPROFILE_SLUG', 'profil' );

The profil cover is not working because of this condition in /buddypress/bp-core/bp-core-attachments.php line 1036

if ( 'profile' === $current_component ) {

Can we compare with the name of the custom profil slug instead of the hardcoded profile text ?

Thank you !

Attachments (1)

6962.01.patch​ (446 bytes ) - added by r-a-y 11 years ago.

Download all attachments as: .zip

Change History (10)

#1 @r-a-y
11 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → 2.6
  • Version 2.5.0 → 2.4.0

Thanks for the report. I can confirm the issue.

I've attached a patch that should fix this.

Last edited 11 years ago by r-a-y (previous) (diff)

@r-a-y
11 years ago

#2 @r-a-y
11 years ago

  • Priority high → normal

This ticket was mentioned in ​Slack in #buddypress by djpaul. ​View the logs.
11 years ago

This ticket was mentioned in ​Slack in #buddypress by dcavins. ​View the logs.
11 years ago

#5 @imath
11 years ago

  • Keywords commit added

01.patch looks good to, thanks a lot @r-a-y.

Version 0, edited 11 years ago by imath (next)

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
10 years ago

#7 @r-a-y
10 years ago

  • Owner set to r-a-y
  • Resolution → fixed
  • Status new → closed

In 10707:

Cover Image: Fix issue when a custom BP_XPROFILE_SLUG is in use.

Fixes #6962.

#8 @DJPaul
10 years ago

  • Component Component - Attachments → Media

#9 @raruto
7 years ago

For some strange reason this patch, in BP v5.1.2, has not yet been applied ...

UPDATE:

Sorry, but I did not check well the path of the file. I got confused because I found a 1:1 bug, but in the following file: /buddypress/bp-mebmers/classes/class-bp-members-component.php line 241

I will open a new ticket.

Last edited 7 years ago by raruto (previous) (diff)
Note: See TracTickets for help on using tickets.