#6958 closed enhancement (fixed)
Update grunt packages
| Reported by: | slaFFik | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.7 |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description (last modified by )
Attached is a list of grunt packages that are outdated right now.
BuddyPress already had an issue with outdated grunt-contrib-imagemin, so I suppose it's a good idea to update others as well.
Attachments (1)
Change History (16)
This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.
10 years ago
#4
@
10 years ago
Netweb said:
Don’t update CSSJanus, replace with RTLCSS (There’s a ticket for that)
[00:18]
Don’t update grunt-util-legacy, it will fail
[00:19]
Upgrading CSSMin will start throwing deprecation errors for banners
[00:19]
Don’t update grunt, there will be conflicts between WP, BP & bbP with that one :disappointed:
and
The grunt-contrib-uglify is a big update, it changes a huge amount of minified JS, but the only sane way to test the update is to commit it and roll with it, letting it soak in /trunk for a while and having peeps test using the /build folder for weirdness in the JS department is essential IMHO
#6
@
10 years ago
- Milestone Under Consideration → 2.6
Can someone test:
Clean trunk
NPM install
Change grunt-contrib-uglify to "~1.0.0"
NPM update
Do you get an error that looks like this? https://gist.github.com/paulgibbs/de9be943ef5076b1c020462e797df94c
I do, netweb doesn't, we need a second opinion!
#8
@
10 years ago
Also may be worth adding I'm using NPM version .3.8.6 and NodeJS version 5.10.0 locally
Have just update to NodeJS version 5.10.1 and also works as expected
#9
@
10 years ago
Core has now also updated grunt-contrib-uglify from ~0.10.0 to ~1.0.1 in wp:changeset:37212
There were/are no issues with Travis CI:
#13
@
10 years ago
- Keywords 2nd-opinion removed
- Milestone Future Release → 2.7
Yolo'd in r10973
The issues I noted in https://buddypress.trac.wordpress.org/ticket/6958#comment:4 still stand I believe, will test and add feedback as needed.
#14
@
10 years ago
- Resolution → fixed
- Status new → closed
I think this is done. Everything seems to be working.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Did you test these? I ask because changing the first digit in this semver pattern normally indicates a breaking change, when it changes. :)