Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#6958 closed enhancement (fixed)

Update grunt packages

Reported by: slaFFik Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Cc:

Description (last modified by slaFFik)

Attached is a list of grunt packages that are outdated right now.
BuddyPress already had an issue with outdated grunt-contrib-imagemin, so I suppose it's a good idea to update others as well.

Attachments (1)

grunt-update.png (16.1 KB) - added by slaFFik 4 years ago.

Download all attachments as: .zip

Change History (16)

@slaFFik
4 years ago

#1 @slaFFik
4 years ago

  • Description modified (diff)

#2 @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to Under Consideration

Did you test these? I ask because changing the first digit in this semver pattern normally indicates a breaking change, when it changes. :)

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


4 years ago

#4 @DJPaul
4 years ago

Netweb said:

Don’t update CSSJanus, replace with RTLCSS (There’s a ticket for that)

[00:18]
Don’t update grunt-util-legacy, it will fail

[00:19]
Upgrading CSSMin will start throwing deprecation errors for banners

[00:19]
Don’t update grunt, there will be conflicts between WP, BP & bbP with that one :disappointed:

and

The grunt-contrib-uglify is a big update, it changes a huge amount of minified JS, but the only sane way to test the update is to commit it and roll with it, letting it soak in /trunk for a while and having peeps test using the /build folder for weirdness in the JS department is essential IMHO

#5 @djpaul
4 years ago

In 10704:

Build tools: update some npm packages to latest stable versions.

See #6958

Props slaFFik, netweb

#6 @DJPaul
4 years ago

  • Milestone changed from Under Consideration to 2.6

Can someone test:

Clean trunk
NPM install
Change grunt-contrib-uglify to "~1.0.0"
NPM update

Do you get an error that looks like this? https://gist.github.com/paulgibbs/de9be943ef5076b1c020462e797df94c

I do, netweb doesn't, we need a second opinion!

#7 @DJPaul
4 years ago

  • Keywords 2nd-opinion added

#8 @netweb
4 years ago

Also may be worth adding I'm using NPM version 3.8.6 and NodeJS version 5.10.0 locally

Have just update to NodeJS version 5.10.1 and also works as expected

Last edited 4 years ago by netweb (previous) (diff)

#9 @netweb
4 years ago

Core has now also updated grunt-contrib-uglify from ~0.10.0 to ~1.0.1 in wp:changeset:37212

There were/are no issues with Travis CI:

#10 @DJPaul
3 years ago

  • Milestone changed from 2.6 to Future Release

#11 @DJPaul
3 years ago

  • Component changed from Tools - Build Process to Build/Test Tools

#12 @DJPaul
3 years ago

  • Type changed from task to enhancement

#13 @netweb
3 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 2.7

Yolo'd in r10973

The issues I noted in https://buddypress.trac.wordpress.org/ticket/6958#comment:4 still stand I believe, will test and add feedback as needed.

#14 @DJPaul
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I think this is done. Everything seems to be working.

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.