Opened 16 years ago
Closed 15 years ago
#695 closed defect (bug) (fixed)
Callback for format activity..+ diff
Reported by: | nicolagreco | Owned by: | nicolagreco |
---|---|---|---|
Milestone: | Priority: | major | |
Severity: | Version: | 1.0 | |
Component: | Keywords: | has-patch, nicolagreco | |
Cc: | nicolagreco |
Description
I think that forcing user to force plugins to add $bp->{$this->component_name}->format_activity_function is not a good idea, because developers are force to add the $bp->my_component->format_activity_function and add the callback only in this way.
That's cool because it's shorter than other methods, but apply filters as in the diff file, might be better
so it can be for example
my_format( $arg1,$arg2.....) { [...] } add_filter( 'bp_activity_format_wiki', 'my_format' );
or replacing the call_user_func, with do_action and adding actions (maybe)
Attachments (1)
Change History (6)
Note: See
TracTickets for help on using
tickets.
In bpdev plugins for example i use $bpdev global and not the $bp to not make it full of sub object and make all more cleaned