Skip to:

Opened 15 years ago

Closed 15 years ago

#695 closed defect (bug) (fixed)

Callback for format activity..+ diff

Reported by: nicolagreco's profile nicolagreco Owned by: nicolagreco's profile nicolagreco
Milestone: Priority: major
Severity: Version: 1.0
Component: Keywords: has-patch, nicolagreco
Cc: nicolagreco


I think that forcing user to force plugins to add $bp->{$this->component_name}->format_activity_function is not a good idea, because developers are force to add the $bp->my_component->format_activity_function and add the callback only in this way.

That's cool because it's shorter than other methods, but apply filters as in the diff file, might be better

so it can be for example

my_format( $arg1,$arg2.....) {
add_filter( 'bp_activity_format_wiki', 'my_format' );

or replacing the call_user_func, with do_action and adding actions (maybe)

Attachments (1)

filter-needed.patch (1.3 KB) - added by nicolagreco 15 years ago.

Download all attachments as: .zip

Change History (6)

#1 @nicolagreco
15 years ago

In bpdev plugins for example i use $bpdev global and not the $bp to not make it full of sub object and make all more cleaned

#2 @nicolagreco
15 years ago

  • Cc nicolagreco added

#3 @apeatling
15 years ago

  • Milestone changed from Activity Streams 1.0 to Activity Streams 1.1

Moving this to 1.1 as it's too late for this sort of change in 1.0.

#4 @(none)
15 years ago

  • Milestone Activity Streams 1.1 deleted

Milestone Activity Streams 1.1 deleted

#5 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

There are major changes in 1.1 in the trunk that will fix this sort of thing.

Note: See TracTickets for help on using tickets.