Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6936 closed defect (bug) (fixed)

Buddypress 2.5.0 Problem when setting up email templates: Situation list blank

Reported by: markob17 Owned by: djpaul
Milestone: 2.5.1 Priority: normal
Severity: normal Version: 2.5.0
Component: Emails Keywords: has-patch
Cc:

Description

Love the new feature to configure html emails, however, the list to change situations is blank (see screenshot). I disabled all plugins and am using the default theme.

Attachments (3)

Capture.PNG (5.1 KB) - added by markob17 4 years ago.
fix_situation_description.patch (1.0 KB) - added by chherbst 4 years ago.
6936.diff (4.9 KB) - added by boonebgorges 4 years ago.

Download all attachments as: .zip

Change History (16)

@markob17
4 years ago

#1 follow-up: @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to Under Consideration

Interesting. It looks like the term descriptions did not get set (at least).

What version of WordPress are you using? Are you using multisite or not? Do you have any unusual BuddyPress configuration settings enabled (if you don't know, then the answer's probably no!)? How did you install BP 2.5 - through the WordPress updater, like normal?

Do you have any other plugins active that do *anything* to taxonomies? Does your theme?

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


4 years ago

#3 @DJPaul
4 years ago

  • Component changed from Not sure to API - Emails
  • Milestone changed from Under Consideration to 2.5.1

Other reports of this from @jersey-peeps and @vinzen on https://buddypress.org/support/topic/buddypress-2-5-0-medici/#post-250506

#4 in reply to: ↑ 1 @markob17
4 years ago

Replying to DJPaul:

Interesting. It looks like the term descriptions did not get set (at least).

What version of WordPress are you using? Are you using multisite or not? Do you have any unusual BuddyPress configuration settings enabled (if you don't know, then the answer's probably no!)? How did you install BP 2.5 - through the WordPress updater, like normal?

Do you have any other plugins active that do *anything* to taxonomies? Does your theme?

Hi @DJPaul,

Here are the answers to your questions. I am using latest version of Wordpress. I am not using multisite. I have no unusual configurations enabled. I installed 2.5.0 through the standard WP updater. I disabled all plugins and enabled the default 2015 theme.

Regards,

Mark

#5 @DJPaul
4 years ago

  • Milestone changed from 2.5.1 to 2.5.2

We've not been able to figure out why this is happening yet (not being able to recreate locally is a pain). We'll continue to look into this.

#6 @chherbst
4 years ago

I am also experiencing this problem, although for me only some situation labels are blank. Others are mixed up. I had a look at the code and found some obvious mistakes. I attached a patch which fixes the problems for me.

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


4 years ago

#8 @boonebgorges
4 years ago

  • Keywords has-patch added
  • Milestone changed from 2.5.2 to 2.5.1

I've confirmed that @chherbst has identified the problem and suggested the correct fix.

The underlying issue is that wp_set_post_terms() returns term taxonomy IDs, not term IDs. WP's internal documentation here is incorrect: https://core.trac.wordpress.org/ticket/36182 Generally, term_id and term_taxonomy_id will be the same for newly created terms like these, but not when the database still contains shared taxonomy terms.

6936.diff contains chherbst's fix, along with a unit test that demonstrates the fix. In order to make testing easier, I broke the email and email-type definitions into standalone functions. @DJPaul I'd like your feedback on whether that's OK, and whether you have better ideas for function names.

@boonebgorges
4 years ago

This ticket was mentioned in Slack in #buddypress by boone. View the logs.


4 years ago

#10 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10647:

Emails: fix situations not being correctly assigned to email posts.

Previously, we were using wp_set_post_terms() to fetch the terms to assign to an email post. However, it turns that that function returns term taxonomy IDs, not term IDs. Generally, term_id and term_taxonomy_id will be the same for newly created terms like these, but not when the database still contains shared taxonomy terms.

Fixes #6936

Props chherbst, boonebgorges

#11 @djpaul
4 years ago

In 10648:

Emails: fix situations not being correctly assigned to email posts.

Previously, we were using wp_set_post_terms() to fetch the terms to assign to an email post. However, it turns that that function returns term taxonomy IDs, not term IDs. Generally, term_id and term_taxonomy_id will be the same for newly created terms like these, but not when the database still contains shared taxonomy terms.

Fixes #6936 (2.5 branch)

Props chherbst, boonebgorges

#12 @heliossolutions
4 years ago

  • Keywords needs-codex added
  • Priority changed from normal to highest
  • Severity changed from normal to critical

Hello Sir

How to change email activation message text ?
I have using buddypress verions 2.5.0

I have try to changes subject,its working fine but message content would not change
add_filter( 'bp_core_signup_send_validation_email_subject', 'custom_buddypress_activation_subject', 10, 2 );

function custom_buddypress_activation_subject( $subject, $user_id ) {

$user = get_userdata( $user_id );
return $user->user_login . ' – Activate your ' . get_bloginfo( 'name' ) . ' account';

}

To change the activation message – its not working in latest buddypress version
add_filter( 'bp_core_signup_send_validation_email_message', 'custom_buddypress_activation_message', 10, 3 );

function custom_buddypress_activation_message( $message, $user_id, $activate_url ) {

$user = get_userdata( $user_id );
return "Hi $user->user_login,

Thanks for registering! To complete the activation of your account please click the following link:
$activate_url
Thanks,
Bharat";
}

Below given filter hook is also deprecated in new version:
(1)bp_core_signup_send_validation_email_message
(2)bp_core_signup_send_validation_email_subject

Which can we use filter and hook instead of bp_core_signup_send_validation_email_message.
Can you please suggest
Is there any hooks /filter functionality so we should overwrite activation email

Last edited 4 years ago by heliossolutions (previous) (diff)

#13 @r-a-y
4 years ago

  • Keywords needs-codex removed
  • Priority changed from highest to normal
  • Severity changed from critical to normal

@heliossolutions - Please do not reopen a completed issue.

Please open a new ticket:
https://buddypress.trac.wordpress.org/newticket?component=API%20-%20Emails

Note: See TracTickets for help on using tickets.