Skip to:
Content

Opened 10 years ago

Closed 9 years ago

#693 closed enhancement (no action required)

The word 'Friendship Requested' must be separated the past tense and the passive voice

Reported by: lilyfan Owned by:
Milestone: 1.2 Priority: minor
Severity: Version: 1.0
Component: Keywords: i18n
Cc: epicalex

Description

The word "Friendship Requested" is useed in two situations:
(1) With the past tense, "I requested a friendship to other."
(2) With the passive voice, "I was requested a friendship by others."

In English, the word "Friendship Requested" is usable for both. But, in some language, the translated string is needed to be separated.

I suggest that separate the word: (1) for "Friendship Requesting" (2) for "Friendship Requested"
And detect each state in the database and the code: bp-friend-ajaz.php, bp-friends-templatetags.php:

Change History (5)

#1 @(none)
10 years ago

  • Milestone Core 1.1 deleted

Milestone Core 1.1 deleted

#2 @apeatling
10 years ago

  • Milestone set to 1.1
  • Type changed from defect to enhancement

#3 @epicalex
10 years ago

  • Cc epicalex added
  • Priority changed from major to minor

I'm a little confused over this one. Are you suggesting that the wording for the button which reads "Friendship Requested" needs to be translatable in two different ways depending on if you have just clicked the button, or if you are coming back to the page to see a button saying "Friendship requested", ie a past tense version?

I think though that actually it is always being used in the passive, regardless of tense? I haven't seen the language files, but in German I'd say "Freundschaftsanfrage anhängig", which translates as "Friendship Request Pending" and could be used universally.

I don't see it as necessary to have two translatable strings on this, since I don't think tense is implied in the English.

(Just to add, the second point about the passive voice isn't quite right. A correct passive would be: "Your friendship was/is requested by another user".)

#4 @apeatling
9 years ago

  • Milestone changed from 1.1 to 1.2

#5 @DJPaul
9 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Please reopen with a future milestone if this is still considered to be desirable; a lot of code has changed in 7 months.

Note: See TracTickets for help on using tickets.